From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f68.google.com ([74.125.83.68]:41248 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933335AbeCGQD6 (ORCPT ); Wed, 7 Mar 2018 11:03:58 -0500 Received: by mail-pg0-f68.google.com with SMTP id q27so1032787pgn.8 for ; Wed, 07 Mar 2018 08:03:58 -0800 (PST) Date: Wed, 7 Mar 2018 08:03:51 -0800 From: Stephen Hemminger To: dsahern@gmail.com Cc: netdev@vger.kernel.org, Stephen Hemminger Subject: Re: [PATCH iproute2-next 2/3] ipmroute: don't complain about unicast routes Message-ID: <20180307080351.11d8bfa9@xeon-e3> In-Reply-To: <20180307010355.5011-3-stephen@networkplumber.org> References: <20180307010355.5011-1-stephen@networkplumber.org> <20180307010355.5011-3-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 6 Mar 2018 17:03:54 -0800 Stephen Hemminger wrote: > From: Stephen Hemminger > > Every non-multicast route prints an error message. > Kernel doesn't filter out unicast routes, it is up to filter function > to do this. > > Signed-off-by: Stephen Hemminger > --- > ip/ipmroute.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/ip/ipmroute.c b/ip/ipmroute.c > index aa5029b44f41..03ca0575e571 100644 > --- a/ip/ipmroute.c > +++ b/ip/ipmroute.c > @@ -75,15 +75,14 @@ int print_mroute(const struct sockaddr_nl *who, struct nlmsghdr *n, void *arg) > fprintf(stderr, "BUG: wrong nlmsg len %d\n", len); > return -1; > } > - if (r->rtm_type != RTN_MULTICAST) { > - fprintf(stderr, "Not a multicast route (type: %s)\n", > - rtnl_rtntype_n2a(r->rtm_type, b1, sizeof(b1))); > + > + if (r->rtm_type != RTN_MULTICAST) > return 0; > - } > > parse_rtattr(tb, RTA_MAX, RTM_RTA(r), len); > table = rtm_get_table(r, tb); > > + > if (filter.tb > 0 && filter.tb != table) > return 0; > Actually, this is a recent kernel regression. Should be fixed there