From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl0-f51.google.com ([209.85.160.51]:43112 "EHLO mail-pl0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753901AbeCGSsa (ORCPT ); Wed, 7 Mar 2018 13:48:30 -0500 Received: by mail-pl0-f51.google.com with SMTP id f23-v6so1838746plr.10 for ; Wed, 07 Mar 2018 10:48:29 -0800 (PST) Date: Wed, 7 Mar 2018 10:48:27 -0800 From: Stephen Hemminger To: davem@davemloft.net Cc: netdev@vger.kernel.org, Stephen Hemminger Subject: Re: [PATCH] hv_netvsc: fix multicast flags and sync Message-ID: <20180307104827.13dfced7@xeon-e3> In-Reply-To: <20180307044051.6357-1-sthemmin@microsoft.com> References: <20180307044051.6357-1-sthemmin@microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 6 Mar 2018 20:40:51 -0800 Stephen Hemminger wrote: > This addresses two problems with recent multicast flags synchronization. > The wrong filter value was being computed (and therefore ARP would > not work on WS2016). And the uc/mc sync logic had locking issues because > it would be called with irq disabled (reported by lockdep). > > Fixes: bee9d41b37ea ("hv_netvsc: propagate rx filters to VF") > Signed-off-by: Stephen Hemminger > --- Self NAK Have a better fix, want to split this up.