From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx3-rdu2.redhat.com ([66.187.233.73]:53280 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751091AbeCGMfd (ORCPT ); Wed, 7 Mar 2018 07:35:33 -0500 Date: Wed, 7 Mar 2018 13:35:30 +0100 From: Sabrina Dubroca To: Atul Gupta Cc: davejwatson@fb.com, davem@davemloft.net, herbert@gondor.apana.org.au, linux-crypto@vger.kernel.org, netdev@vger.kernel.org, ganeshgr@chelsio.com Subject: Re: [PATCH v9 crypto 02/12] ethtool: enable Inline TLS in HW Message-ID: <20180307123530.GC20949@bistromath.localdomain> References: <1520350523-11743-1-git-send-email-atul.gupta@chelsio.com> <1520350642-11852-1-git-send-email-atul.gupta@chelsio.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1520350642-11852-1-git-send-email-atul.gupta@chelsio.com> Sender: netdev-owner@vger.kernel.org List-ID: Since you're saying the driver supports offloading TLS records to the HW, why not call the feature "record offloading"? With, for example, NETIF_F_HW_TLS_RECORD as the feature, and maybe "tls-hw-record" for the ethtool string. This "Inline TLS" name sounds rather like marketing to me. 2018-03-06, 21:07:22 +0530, Atul Gupta wrote: > Signed-off-by: Atul Gupta There should be a description here of what the feature covers, so that other drivers can decide if it matches what their HW supports. -- Sabrina