From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:39482 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1754696AbeCHQNB (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 8 Mar 2018 11:13:01 -0500
Date: Thu, 08 Mar 2018 11:12:56 -0500 (EST)
Message-Id: <20180308.111256.1393059893437825412.davem@davemloft.net>
To: pabeni@redhat.com
Cc: netdev@vger.kernel.org, maheshb@google.com, jbenc@redhat.com
Subject: Re: [PATCH net-next] ipvlan: properly annotate rx_handler access
From: David Miller <davem@davemloft.net>
In-Reply-To: <3eef25d5e0b41aa3429ba31f87264c17e75de9e6.1520500821.git.pabeni@redhat.com>
References: <3eef25d5e0b41aa3429ba31f87264c17e75de9e6.1520500821.git.pabeni@redhat.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Paolo Abeni <pabeni@redhat.com>
Date: Thu,  8 Mar 2018 10:29:30 +0100

> The rx_handler field is rcu-protected, but I forgot to use the
> proper accessor while refactoring netif_is_ipvlan_port(). Such
> function only check the rx_handler value, so it is safe, but we need
> to properly read rx_handler via rcu_access_pointer() to avoid sparse
> warnings.
> 
> Fixes: 1ec54cb44e67 ("net: unpollute priv_flags space")
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>

Applied.