From: David Miller <davem@davemloft.net>
To: u9012063@gmail.com
Cc: netdev@vger.kernel.org, pshelar@ovn.org, jbenc@redhat.com
Subject: Re: [PATCHv2 net-next] openvswitch: fix vport packet length check.
Date: Thu, 08 Mar 2018 12:50:48 -0500 (EST) [thread overview]
Message-ID: <20180308.125048.134021595909061097.davem@davemloft.net> (raw)
In-Reply-To: <1520465928-22181-1-git-send-email-u9012063@gmail.com>
From: William Tu <u9012063@gmail.com>
Date: Wed, 7 Mar 2018 15:38:48 -0800
> When sending a packet to a tunnel device, the dev's hard_header_len
> could be larger than the skb->len in function packet_length().
> In the case of ip6gretap/erspan, hard_header_len = LL_MAX_HEADER + t_hlen,
> which is around 180, and an ARP packet sent to this tunnel has
> skb->len = 42. This causes the 'unsign int length' to become super
> large because it is negative value, causing the later ovs_vport_send
> to drop it due to over-mtu size. The patch fixes it by setting it to 0.
>
> Signed-off-by: William Tu <u9012063@gmail.com>
> ---
> v1->v2:
> replace the return type from unsigned int to int
Applied, thanks.
prev parent reply other threads:[~2018-03-08 17:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-07 23:38 [PATCHv2 net-next] openvswitch: fix vport packet length check William Tu
2018-03-08 1:01 ` Pravin Shelar
2018-03-08 17:50 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180308.125048.134021595909061097.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jbenc@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@ovn.org \
--cc=u9012063@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).