From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shards.monkeyblade.net ([184.105.139.130]:40812 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752135AbeCHRut (ORCPT ); Thu, 8 Mar 2018 12:50:49 -0500 Date: Thu, 08 Mar 2018 12:50:48 -0500 (EST) Message-Id: <20180308.125048.134021595909061097.davem@davemloft.net> To: u9012063@gmail.com Cc: netdev@vger.kernel.org, pshelar@ovn.org, jbenc@redhat.com Subject: Re: [PATCHv2 net-next] openvswitch: fix vport packet length check. From: David Miller In-Reply-To: <1520465928-22181-1-git-send-email-u9012063@gmail.com> References: <1520465928-22181-1-git-send-email-u9012063@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: From: William Tu Date: Wed, 7 Mar 2018 15:38:48 -0800 > When sending a packet to a tunnel device, the dev's hard_header_len > could be larger than the skb->len in function packet_length(). > In the case of ip6gretap/erspan, hard_header_len = LL_MAX_HEADER + t_hlen, > which is around 180, and an ARP packet sent to this tunnel has > skb->len = 42. This causes the 'unsign int length' to become super > large because it is negative value, causing the later ovs_vport_send > to drop it due to over-mtu size. The patch fixes it by setting it to 0. > > Signed-off-by: William Tu > --- > v1->v2: > replace the return type from unsigned int to int Applied, thanks.