From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shards.monkeyblade.net ([184.105.139.130]:40848 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936048AbeCHRwB (ORCPT ); Thu, 8 Mar 2018 12:52:01 -0500 Date: Thu, 08 Mar 2018 12:52:00 -0500 (EST) Message-Id: <20180308.125200.1907923295220428027.davem@davemloft.net> To: tlfalcon@linux.vnet.ibm.com Cc: netdev@vger.kernel.org, nfont@linux.vnet.ibm.com, jallen@linux.vnet.ibm.com Subject: Re: [RESEND PATCH 0/3 net-next] ibmvnic: Clean up net close and fix reset bug From: David Miller In-Reply-To: <1520466707-17806-1-git-send-email-tlfalcon@linux.vnet.ibm.com> References: <1520466707-17806-1-git-send-email-tlfalcon@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: From: Thomas Falcon Date: Wed, 7 Mar 2018 17:51:44 -0600 > This patch set cleans up and reorganizes the driver's net_device > close function and leverages that to fix up a bug that can occur > during some device resets. Some reset cases require the backing > adapter to be disabled before continuing, but other cases, such as > during a device failover or partition migration, do not require this > step. Since the device will not be initialized at this stage and > its command-processing queue is closed, do not send the request to > disable the device as it could result in an error or timeout > disrupting the reset. Series applied,thanks.