From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl0-f52.google.com ([209.85.160.52]:36543 "EHLO mail-pl0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752059AbeCHPik (ORCPT ); Thu, 8 Mar 2018 10:38:40 -0500 Received: by mail-pl0-f52.google.com with SMTP id 61-v6so3508580plf.3 for ; Thu, 08 Mar 2018 07:38:40 -0800 (PST) Date: Thu, 8 Mar 2018 07:38:37 -0800 From: Stephen Hemminger To: Tariq Toukan Cc: David Ahern , netdev@vger.kernel.org Subject: Re: [PATCH iproute2-next] ip-address: Fix negative prints of large TX rate limits Message-ID: <20180308073837.7c21b7d2@xeon-e3> In-Reply-To: <1520516907-17956-1-git-send-email-tariqt@mellanox.com> References: <1520516907-17956-1-git-send-email-tariqt@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: On Thu, 8 Mar 2018 15:48:27 +0200 Tariq Toukan wrote: > if (vf_tx_rate->rate) > print_int(PRINT_ANY, > "tx_rate", > - ", tx rate %d (Mbps)", > + ", tx rate %u (Mbps)", > vf_tx_rate->rate) JSON output has same sign bug. You need to use print_uint here.