* [PATCH 1/2 net-next] net/ncsi: use kfree_skb() instead of kfree()
@ 2018-03-08 9:36 Dan Carpenter
2018-03-09 2:50 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2018-03-08 9:36 UTC (permalink / raw)
To: David S. Miller, Samuel Mendoza-Jonas; +Cc: netdev, kernel-janitors
We're supposed to use kfree_skb() to free these sk_buffs.
Fixes: 955dc68cb9b2 ("net/ncsi: Add generic netlink family")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/net/ncsi/ncsi-netlink.c b/net/ncsi/ncsi-netlink.c
index d4201665a580..b73239b76349 100644
--- a/net/ncsi/ncsi-netlink.c
+++ b/net/ncsi/ncsi-netlink.c
@@ -183,7 +183,7 @@ static int ncsi_pkg_info_nl(struct sk_buff *msg, struct genl_info *info)
hdr = genlmsg_put(skb, info->snd_portid, info->snd_seq,
&ncsi_genl_family, 0, NCSI_CMD_PKG_INFO);
if (!hdr) {
- kfree(skb);
+ kfree_skb(skb);
return -EMSGSIZE;
}
@@ -204,7 +204,7 @@ static int ncsi_pkg_info_nl(struct sk_buff *msg, struct genl_info *info)
err:
genlmsg_cancel(skb, hdr);
- kfree(skb);
+ kfree_skb(skb);
return rc;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/2 net-next] net/ncsi: use kfree_skb() instead of kfree()
2018-03-08 9:36 [PATCH 1/2 net-next] net/ncsi: use kfree_skb() instead of kfree() Dan Carpenter
@ 2018-03-09 2:50 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-03-09 2:50 UTC (permalink / raw)
To: dan.carpenter; +Cc: sam, netdev, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Thu, 8 Mar 2018 12:36:04 +0300
> We're supposed to use kfree_skb() to free these sk_buffs.
>
> Fixes: 955dc68cb9b2 ("net/ncsi: Add generic netlink family")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-09 2:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-08 9:36 [PATCH 1/2 net-next] net/ncsi: use kfree_skb() instead of kfree() Dan Carpenter
2018-03-09 2:50 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).