From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from vs10.datenmanufaktur-hosting.net ([185.138.26.202]:50648 "EHLO vs81.iboxed.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750966AbeCHLUR (ORCPT ); Thu, 8 Mar 2018 06:20:17 -0500 From: Alexander Kurz To: "David S . Miller" Cc: "Andrew F . Davis" , linux-usb@vger.kernel.org, netdev@vger.kernel.org, Freddy Xin , Alexander Kurz Subject: [PATCH v2 1/2] net: usb: asix88179_178a: set permanent address once only Date: Thu, 8 Mar 2018 11:19:53 +0000 Message-Id: <20180308111954.28885-1-akurz@blala.de> Sender: netdev-owner@vger.kernel.org List-ID: The permanent address of asix88179_178a devices is read at probe time and should not be overwritten later. Otherwise it may be overwritten unintentionally with a configured address. Signed-off-by: Alexander Kurz --- drivers/net/usb/ax88179_178a.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c index f32261ecd215..a6ef75907ae9 100644 --- a/drivers/net/usb/ax88179_178a.c +++ b/drivers/net/usb/ax88179_178a.c @@ -1556,7 +1556,6 @@ static int ax88179_reset(struct usbnet *dev) ax88179_read_cmd(dev, AX_ACCESS_MAC, AX_NODE_ID, ETH_ALEN, ETH_ALEN, dev->net->dev_addr); - memcpy(dev->net->perm_addr, dev->net->dev_addr, ETH_ALEN); /* RX bulk configuration */ memcpy(tmp, &AX88179_BULKIN_SIZE[0], 5); -- 2.11.0