[linux-next:master 6182/6533] net/rds/message.c:70:27: sparse: symbol 'rds_info_from_znotifier' was not declared. Should it be static?

[linux-next:master 6182/6533] net/rds/message.c:70:27: sparse: symbol 'rds_info_from_znotifier' was not declared. Should it be static?

[kbuild test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   c6f1a8c953479b390458e36fb838d96199a5f466
commit: 9426bbc6de99b8649d897b94e8f5916b58195643 [6182/6533] rds: use list structure to track information for zerocopy completion notification
reproduce:
        # apt-get install sparse
        git checkout 9426bbc6de99b8649d897b94e8f5916b58195643
        make ARCH=x86_64 allmodconfig
        make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> net/rds/message.c:70:27: sparse: symbol 'rds_info_from_znotifier' was not declared. Should it be static?
   net/rds/message.c:358:5: sparse: symbol 'rds_message_zcopy_from_user' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[RFC PATCH linux-next] rds: rds_info_from_znotifier() can be static

[kbuild test robot]

Fixes: 9426bbc6de99 ("rds: use list structure to track information for zerocopy completion notification")
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 message.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/rds/message.c b/net/rds/message.c
index 90dcdcf..f422b2f 100644
--- a/net/rds/message.c
+++ b/net/rds/message.c
@@ -67,7 +67,7 @@ static inline bool rds_zcookie_add(struct rds_msg_zcopy_info *info, u32 cookie)
 	return true;
 }
 
-struct rds_msg_zcopy_info *rds_info_from_znotifier(struct rds_znotifier *znotif)
+static struct rds_msg_zcopy_info *rds_info_from_znotifier(struct rds_znotifier *znotif)
 {
 	return container_of(znotif, struct rds_msg_zcopy_info, znotif);
 }

Re: [RFC PATCH linux-next] rds: rds_info_from_znotifier() can be static

[David Miller]

From: kbuild test robot <fengguang.wu@intel.com>
Date: Thu, 8 Mar 2018 19:37:30 +0800

> Fixes: 9426bbc6de99 ("rds: use list structure to track information for zerocopy completion notification")
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>

Applied.