From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:53394 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751182AbeCIQZt (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 9 Mar 2018 11:25:49 -0500
Date: Fri, 09 Mar 2018 11:25:47 -0500 (EST)
Message-Id: <20180309.112547.816502907859320044.davem@davemloft.net>
To: mrv@mojatatu.com
Cc: netdev@vger.kernel.org, kernel@mojatatu.com, jhs@mojatatu.com,
        xiyou.wangcong@gmail.com, jiri@resnulli.us
Subject: Re: [PATCH v3 net-next 0/4] Fix event generation for actions batch
 Add/Delete mode
From: David Miller <davem@davemloft.net>
In-Reply-To: <1520546360-15331-1-git-send-email-mrv@mojatatu.com>
References: <1520546360-15331-1-git-send-email-mrv@mojatatu.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Roman Mashak <mrv@mojatatu.com>
Date: Thu,  8 Mar 2018 16:59:16 -0500

> When adding or deleting a batch of entries, the kernel sends upto
> TCA_ACT_MAX_PRIO entries in an event to user space. However it does not
> consider that the action sizes may vary and require different skb sizes.
> 
> For example :
> 
> % cat tc-batch.sh
> #!/bin/bash
> TC="sudo /mnt/iproute2.git/tc/tc"
> 
> $TC actions flush action gact
> for i in `seq 1 $1`;
> do
>    cmd="action pass index $i "
>    args=$args$cmd
> done
> $TC actions add $args
> %
> % ./tc-batch.sh 32
> Error: Failed to fill netlink attributes while adding TC action.
> We have an error talking to the kernel
> %
> 
> This patchset introduces new callback in tc_action_ops, which calculates
> the action size, and passes size to tcf_add_notify()/tcf_del_notify(). The
> patch fixes act_gact, and the rest of actions will be updated in the
> follow-up patches.
> 
> v3:
>    Fixed tcf_action_fill_size() to return shared attrs length when
>    action ->get_fill_size() isn't implemented.
> v2:
>    Restructured patches to make them bisectable.

This looks better, series applied, thanks.