From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:53560 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751192AbeCIQmt (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 9 Mar 2018 11:42:49 -0500
Date: Fri, 09 Mar 2018 11:42:48 -0500 (EST)
Message-Id: <20180309.114248.1653162492764195930.davem@davemloft.net>
To: dja@axtens.net
Cc: netdev@vger.kernel.org, daniel@iogearbox.net,
        marcelo.leitner@gmail.com
Subject: Re: [PATCH] net: use skb_is_gso_sctp() instead of open-coding
From: David Miller <davem@davemloft.net>
In-Reply-To: <20180309030609.4806-1-dja@axtens.net>
References: <20180309030609.4806-1-dja@axtens.net>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Daniel Axtens <dja@axtens.net>
Date: Fri,  9 Mar 2018 14:06:09 +1100

> As well as the basic conversion, I noticed that a lot of the
> SCTP code checks gso_type without first checking skb_is_gso()
> so I have added that where appropriate.
> 
> Also, document the helper.
> 
> Cc: Daniel Borkmann <daniel@iogearbox.net>
> Cc: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
> Signed-off-by: Daniel Axtens <dja@axtens.net>

Applied, thank you.

It might be nice to consolidate the TCP tests with a helper
like "skb_is_gso_tcp()", but that's just a tidy up and not
so pressing.