From: David Miller <davem@davemloft.net>
To: gustavo@embeddedor.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
garsilva@embeddedor.com
Subject: Re: [PATCH] pktgen: Remove VLA usage
Date: Fri, 09 Mar 2018 11:58:10 -0500 (EST) [thread overview]
Message-ID: <20180309.115810.954232560207995724.davem@davemloft.net> (raw)
In-Reply-To: <20180309054340.GA14439@embeddedgus>
From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Date: Thu, 8 Mar 2018 23:43:40 -0600
> In preparation to enabling -Wvla, remove VLA usage and replace it
> with a fixed-length array instead.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> David,
>
> I'm not sure how often this function is being called and,
> depending on the frequency it may be worth to use
> dynamic memory allocation instead?
It happens every time a config setting is made via the sysfs
files when debug is enabled.
This is not something that happens often.
So your patch is fine, applied to net-next, thanks.
next prev parent reply other threads:[~2018-03-09 16:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-09 5:43 [PATCH] pktgen: Remove VLA usage Gustavo A. R. Silva
2018-03-09 16:58 ` David Miller [this message]
2018-03-09 18:33 ` Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180309.115810.954232560207995724.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=garsilva@embeddedor.com \
--cc=gustavo@embeddedor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).