From: Jiri Benc <jbenc@redhat.com>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [PATCH net-next] net: do not create fallback tunnels for non-default namespaces
Date: Fri, 9 Mar 2018 14:08:40 +0100 [thread overview]
Message-ID: <20180309140840.324bf341@redhat.com> (raw)
In-Reply-To: <CANn89i+9w=2U_kkJc+UBZ5CDz=bszp43Guv4+=2f634pXFG9vg@mail.gmail.com>
On Fri, 9 Mar 2018 04:53:07 -0800, Eric Dumazet wrote:
> Unless you bring it up ;)
Often, you need some options to be specified, thus you end up creating
another interface anyway.
> Compatibility problems, mostly.
> Some users might depend on existing behavior.
How is this a compatibility problem, when the user has to opt in?
Without the default value, the kernel behaves as before. I'm sorry,
I don't see the problem, what am I missing?
> You and me would not care of breaking our setups, but maybe not
> unaware people out there.
Sure, that's why this is an option and it defaults to off.
> Since init_ns is created at boot time before the sysctl can be
> changed, we rather should not change the default behavior for init_ns.
This could be a problem for built in drivers. With modules, I'm
perfectly happy doing this in initrd :-)
To behave consistently in all cases, we might consider adding a boot
option for this, too, though.
Jiri
next prev parent reply other threads:[~2018-03-09 13:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-08 20:51 [PATCH net-next] net: do not create fallback tunnels for non-default namespaces Eric Dumazet
2018-03-09 11:06 ` Jiri Benc
2018-03-09 12:53 ` Eric Dumazet
2018-03-09 13:08 ` Jiri Benc [this message]
2018-03-09 13:18 ` Eric Dumazet
2018-03-09 16:23 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180309140840.324bf341@redhat.com \
--to=jbenc@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).