From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx3-rdu2.redhat.com ([66.187.233.73]:53120 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751082AbeCINIn (ORCPT ); Fri, 9 Mar 2018 08:08:43 -0500 Date: Fri, 9 Mar 2018 14:08:40 +0100 From: Jiri Benc To: Eric Dumazet Cc: "David S . Miller" , netdev , Eric Dumazet Subject: Re: [PATCH net-next] net: do not create fallback tunnels for non-default namespaces Message-ID: <20180309140840.324bf341@redhat.com> In-Reply-To: References: <20180308205141.77868-1-edumazet@google.com> <20180309120636.429d8796@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: On Fri, 9 Mar 2018 04:53:07 -0800, Eric Dumazet wrote: > Unless you bring it up ;) Often, you need some options to be specified, thus you end up creating another interface anyway. > Compatibility problems, mostly. > Some users might depend on existing behavior. How is this a compatibility problem, when the user has to opt in? Without the default value, the kernel behaves as before. I'm sorry, I don't see the problem, what am I missing? > You and me would not care of breaking our setups, but maybe not > unaware people out there. Sure, that's why this is an option and it defaults to off. > Since init_ns is created at boot time before the sysctl can be > changed, we rather should not change the default behavior for init_ns. This could be a problem for built in drivers. With modules, I'm perfectly happy doing this in initrd :-) To behave consistently in all cases, we might consider adding a boot option for this, too, though. Jiri