From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from mx4.wp.pl ([212.77.101.12]:35065 "EHLO mx4.wp.pl"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S932276AbeCIXOr (ORCPT <rfc822;netdev@vger.kernel.org>);
        Fri, 9 Mar 2018 18:14:47 -0500
Date: Fri, 9 Mar 2018 15:14:28 -0800
From: Jakub Kicinski <kubakici@wp.pl>
To: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org
Subject: Re: [PATCH 12/15] ice: Add stats and ethtool support
Message-ID: <20180309151428.4d73358c@cakuba.netronome.com>
In-Reply-To: <20180309172136.9073-13-anirudh.venkataramanan@intel.com>
References: <20180309172136.9073-1-anirudh.venkataramanan@intel.com>
        <20180309172136.9073-13-anirudh.venkataramanan@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Fri,  9 Mar 2018 09:21:33 -0800, Anirudh Venkataramanan wrote:
> +static const struct ice_stats ice_net_stats[] = {
> +	ICE_NETDEV_STAT(rx_packets),
> +	ICE_NETDEV_STAT(tx_packets),
> +	ICE_NETDEV_STAT(rx_bytes),
> +	ICE_NETDEV_STAT(tx_bytes),
> +	ICE_NETDEV_STAT(rx_errors),
> +	ICE_NETDEV_STAT(tx_errors),
> +	ICE_NETDEV_STAT(rx_dropped),
> +	ICE_NETDEV_STAT(tx_dropped),
> +	ICE_NETDEV_STAT(multicast),
> +	ICE_NETDEV_STAT(rx_length_errors),
> +	ICE_NETDEV_STAT(rx_crc_errors),
> +};

Please don't duplicate standard netdev stats in ethtool -S.