From: Igor Mitsyanko <igor.mitsyanko.os@quantenna.com>
To: bridge@lists.linux-foundation.org, netdev@vger.kernel.org
Cc: ivecera@redhat.com, igor.mitsyanko.os@quantenna.com,
jiri@resnulli.us, sergey.matyukevich.os@quantenna.com,
ashevchenko@quantenna.com, smaksimenko@quantenna.com,
dlebed@quantenna.com
Subject: [RFC PATCH net-next 5/5] bridge: verify "HW only" flags can't be set without HW support
Date: Fri, 9 Mar 2018 19:03:08 -0800 [thread overview]
Message-ID: <20180310030308.12947-6-igor.mitsyanko.os@quantenna.com> (raw)
In-Reply-To: <20180310030308.12947-1-igor.mitsyanko.os@quantenna.com>
Setting bridge flag BR_FLOOD_OFFLOAD only makes sense if underlying
port hardware advertises support for it. Make sure kernel checks that
condition before allowing to update the flag value.
Signed-off-by: Igor Mitsyanko <igor.mitsyanko.os@quantenna.com>
---
net/bridge/br_private.h | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/net/bridge/br_private.h b/net/bridge/br_private.h
index a6d2f2b..6d2f8b1 100644
--- a/net/bridge/br_private.h
+++ b/net/bridge/br_private.h
@@ -50,6 +50,9 @@ enum {
/* Path to usermode spanning tree program */
#define BR_STP_PROG "/sbin/bridge-stp"
+/* Flags that can only be set if HW supports it */
+#define BR_PORT_FLAGS_HW_ONLY BR_FLOOD_OFFLOAD
+
typedef struct bridge_id bridge_id;
typedef struct mac_addr mac_addr;
typedef __u16 port_id;
@@ -1150,7 +1153,7 @@ static inline int br_switchdev_set_port_flag(struct net_bridge_port *p,
unsigned long flags,
unsigned long mask)
{
- return 0;
+ return mask & BR_PORT_FLAGS_HW_ONLY ? -EOPNOTSUPP : 0;
}
static inline void
--
2.9.5
next prev parent reply other threads:[~2018-03-10 3:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-10 3:03 [PATCH net-next 0/5] Switchdev: flooding offload option Igor Mitsyanko
2018-03-10 3:03 ` [PATCH net-next 1/5] bridge: initialize port flags with switchdev defaults Igor Mitsyanko
2018-03-10 16:30 ` Andrew Lunn
2018-03-12 18:44 ` Igor Mitsyanko
2018-03-10 16:32 ` Stephen Hemminger
2018-03-12 19:03 ` Igor Mitsyanko
2018-03-10 3:03 ` [PATCH net-next 2/5] bridge: propagate BR_ flags updates through sysfs to switchdev Igor Mitsyanko
2018-03-10 16:38 ` Andrew Lunn
2018-03-12 20:07 ` Igor Mitsyanko
2018-03-10 3:03 ` [RFC PATCH net-next 3/5] bridge: allow switchdev port to handle flooding by itself Igor Mitsyanko
2018-03-10 16:55 ` Andrew Lunn
2018-03-12 23:00 ` Igor Mitsyanko
2018-03-13 1:11 ` Andrew Lunn
2018-03-13 14:41 ` Roopa Prabhu
2018-03-10 3:03 ` [RFC PATCH net-next 4/5] bridge: provide sysfs and netlink interface to set BR_FLOOD_OFFLOAD Igor Mitsyanko
2018-03-10 3:03 ` Igor Mitsyanko [this message]
2018-03-10 22:08 ` [PATCH net-next 0/5] Switchdev: flooding offload option Andrew Lunn
2018-03-12 23:08 ` Igor Mitsyanko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180310030308.12947-6-igor.mitsyanko.os@quantenna.com \
--to=igor.mitsyanko.os@quantenna.com \
--cc=ashevchenko@quantenna.com \
--cc=bridge@lists.linux-foundation.org \
--cc=dlebed@quantenna.com \
--cc=ivecera@redhat.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=sergey.matyukevich.os@quantenna.com \
--cc=smaksimenko@quantenna.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).