From: Stephen Hemminger <stephen@networkplumber.org>
To: Igor Mitsyanko <igor.mitsyanko.os@quantenna.com>
Cc: ivecera@redhat.com, jiri@resnulli.us, netdev@vger.kernel.org,
bridge@lists.linux-foundation.org,
sergey.matyukevich.os@quantenna.com, ashevchenko@quantenna.com,
smaksimenko@quantenna.com, dlebed@quantenna.com
Subject: Re: [PATCH net-next 1/5] bridge: initialize port flags with switchdev defaults
Date: Sat, 10 Mar 2018 08:32:34 -0800 [thread overview]
Message-ID: <20180310083234.47db5f06@xeon-e3> (raw)
In-Reply-To: <20180310030308.12947-2-igor.mitsyanko.os@quantenna.com>
On Fri, 9 Mar 2018 19:03:04 -0800
Igor Mitsyanko <igor.mitsyanko.os@quantenna.com> wrote:
> Default bridge port flags for switchdev devices can be different from
> what is used in bridging core. Get default value from switchdev itself
> on port initialization.
>
> Signed-off-by: Igor Mitsyanko <igor.mitsyanko.os@quantenna.com>
> ---
Yes hardware devices may come it with different default values.
But the user experience on Linux needs to be consistent.
Instead, it makes more sense to me for each device driver using switchdev
to program to the values that it sees in the bridge.
Please revise this.
next prev parent reply other threads:[~2018-03-10 16:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-10 3:03 [PATCH net-next 0/5] Switchdev: flooding offload option Igor Mitsyanko
2018-03-10 3:03 ` [PATCH net-next 1/5] bridge: initialize port flags with switchdev defaults Igor Mitsyanko
2018-03-10 16:30 ` Andrew Lunn
2018-03-12 18:44 ` Igor Mitsyanko
2018-03-10 16:32 ` Stephen Hemminger [this message]
2018-03-12 19:03 ` Igor Mitsyanko
2018-03-10 3:03 ` [PATCH net-next 2/5] bridge: propagate BR_ flags updates through sysfs to switchdev Igor Mitsyanko
2018-03-10 16:38 ` Andrew Lunn
2018-03-12 20:07 ` Igor Mitsyanko
2018-03-10 3:03 ` [RFC PATCH net-next 3/5] bridge: allow switchdev port to handle flooding by itself Igor Mitsyanko
2018-03-10 16:55 ` Andrew Lunn
2018-03-12 23:00 ` Igor Mitsyanko
2018-03-13 1:11 ` Andrew Lunn
2018-03-13 14:41 ` Roopa Prabhu
2018-03-10 3:03 ` [RFC PATCH net-next 4/5] bridge: provide sysfs and netlink interface to set BR_FLOOD_OFFLOAD Igor Mitsyanko
2018-03-10 3:03 ` [RFC PATCH net-next 5/5] bridge: verify "HW only" flags can't be set without HW support Igor Mitsyanko
2018-03-10 22:08 ` [PATCH net-next 0/5] Switchdev: flooding offload option Andrew Lunn
2018-03-12 23:08 ` Igor Mitsyanko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180310083234.47db5f06@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=ashevchenko@quantenna.com \
--cc=bridge@lists.linux-foundation.org \
--cc=dlebed@quantenna.com \
--cc=igor.mitsyanko.os@quantenna.com \
--cc=ivecera@redhat.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=sergey.matyukevich.os@quantenna.com \
--cc=smaksimenko@quantenna.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox