From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from mail-pf0-f172.google.com ([209.85.192.172]:37072 "EHLO
        mail-pf0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932462AbeCJQh7 (ORCPT
        <rfc822;netdev@vger.kernel.org>); Sat, 10 Mar 2018 11:37:59 -0500
Received: by mail-pf0-f172.google.com with SMTP id h11so2556930pfn.4
        for <netdev@vger.kernel.org>; Sat, 10 Mar 2018 08:37:59 -0800 (PST)
Date: Sat, 10 Mar 2018 08:37:52 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org
Subject: Re: [PATCH 12/15] ice: Add stats and ethtool support
Message-ID: <20180310083752.320dab33@xeon-e3>
In-Reply-To: <20180309172136.9073-13-anirudh.venkataramanan@intel.com>
References: <20180309172136.9073-1-anirudh.venkataramanan@intel.com>
        <20180309172136.9073-13-anirudh.venkataramanan@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Fri,  9 Mar 2018 09:21:33 -0800
Anirudh Venkataramanan <anirudh.venkataramanan@intel.com> wrote:

> +	/* VSI stats */
> +	struct rtnl_link_stats64 net_stats;
> +	struct rtnl_link_stats64 net_stats_prev;
> +	struct ice_eth_stats eth_stats;
> +	struct ice_eth_stats eth_stats_prev;
> +

There is already a stats64 in netdev.
You might want to also consider per-cpu statistics since incrementing
a shared counter is cache unfriendly.