From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl0-f54.google.com ([209.85.160.54]:43239 "EHLO mail-pl0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751166AbeCJQmp (ORCPT ); Sat, 10 Mar 2018 11:42:45 -0500 Received: by mail-pl0-f54.google.com with SMTP id f23-v6so6946472plr.10 for ; Sat, 10 Mar 2018 08:42:45 -0800 (PST) Date: Sat, 10 Mar 2018 08:42:43 -0800 From: Stephen Hemminger To: Anirudh Venkataramanan Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org Subject: Re: [PATCH 12/15] ice: Add stats and ethtool support Message-ID: <20180310084243.4584ccd9@xeon-e3> In-Reply-To: <20180309172136.9073-13-anirudh.venkataramanan@intel.com> References: <20180309172136.9073-1-anirudh.venkataramanan@intel.com> <20180309172136.9073-13-anirudh.venkataramanan@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: On Fri, 9 Mar 2018 09:21:33 -0800 Anirudh Venkataramanan wrote: > + /* VSI stats */ > + struct rtnl_link_stats64 net_stats; > + struct rtnl_link_stats64 net_stats_prev; > + struct ice_eth_stats eth_stats; > + struct ice_eth_stats eth_stats_prev; You also don't need current and previous as separate copies since previous is only used while computing the current values.