From: Stephen Hemminger <stephen@networkplumber.org>
To: Tariq Toukan <tariqt@mellanox.com>
Cc: David Ahern <dsahern@gmail.com>, netdev@vger.kernel.org
Subject: Re: [PATCH V2 iproute2-next] ip-address: Fix negative prints of large TX rate limits
Date: Sat, 10 Mar 2018 09:01:06 -0800 [thread overview]
Message-ID: <20180310090106.6d87e2f2@xeon-e3> (raw)
In-Reply-To: <1520525306-26614-1-git-send-email-tariqt@mellanox.com>
On Thu, 8 Mar 2018 18:08:26 +0200
Tariq Toukan <tariqt@mellanox.com> wrote:
> TX rate limit fields are unsigned (__u32).
> Use %u and print_uint when printing.
>
> Tested:
> $ ip link set ens1 vf 1 rate 2294967296
> $ ip link show |grep -iE "vf 1" | grep rate
>
> before:
> vf 1 MAC 00:00:00:00:00:00, tx rate -2000000000 (Mbps), max_tx_rate -2000000000Mbps, ...
>
> after:
> vf 1 MAC 00:00:00:00:00:00, tx rate 2294967296 (Mbps), max_tx_rate 2294967296Mbps, ...
>
> Fixes: 3fd86630876a ("iproute2: rework SR-IOV VF support")
> Fixes: 8c29ae7cc249 ("ip link: Fix crash on older kernels when show VF dev")
> Fixes: f89a2a05ffa9 ("Add support to configure SR-IOV VF minimum and maximum Tx rate through ip tool")
> Fixes: ae7229d5f99e ("ip: Add support for setting and showing SR-IOV virtual funtion link params")
> Fixes: d0e720111aad ("ip: ipaddress.c: add support for json output")
> Signed-off-by: Tariq Toukan <tariqt@mellanox.com>
Applied to master.
prev parent reply other threads:[~2018-03-10 17:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-08 16:08 [PATCH V2 iproute2-next] ip-address: Fix negative prints of large TX rate limits Tariq Toukan
2018-03-08 18:16 ` David Ahern
2018-03-10 17:01 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180310090106.6d87e2f2@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=tariqt@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).