From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl0-f50.google.com ([209.85.160.50]:36194 "EHLO mail-pl0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751038AbeCJRBq (ORCPT ); Sat, 10 Mar 2018 12:01:46 -0500 Received: by mail-pl0-f50.google.com with SMTP id 61-v6so6961623plf.3 for ; Sat, 10 Mar 2018 09:01:46 -0800 (PST) Date: Sat, 10 Mar 2018 09:01:06 -0800 From: Stephen Hemminger To: Tariq Toukan Cc: David Ahern , netdev@vger.kernel.org Subject: Re: [PATCH V2 iproute2-next] ip-address: Fix negative prints of large TX rate limits Message-ID: <20180310090106.6d87e2f2@xeon-e3> In-Reply-To: <1520525306-26614-1-git-send-email-tariqt@mellanox.com> References: <1520525306-26614-1-git-send-email-tariqt@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: On Thu, 8 Mar 2018 18:08:26 +0200 Tariq Toukan wrote: > TX rate limit fields are unsigned (__u32). > Use %u and print_uint when printing. > > Tested: > $ ip link set ens1 vf 1 rate 2294967296 > $ ip link show |grep -iE "vf 1" | grep rate > > before: > vf 1 MAC 00:00:00:00:00:00, tx rate -2000000000 (Mbps), max_tx_rate -2000000000Mbps, ... > > after: > vf 1 MAC 00:00:00:00:00:00, tx rate 2294967296 (Mbps), max_tx_rate 2294967296Mbps, ... > > Fixes: 3fd86630876a ("iproute2: rework SR-IOV VF support") > Fixes: 8c29ae7cc249 ("ip link: Fix crash on older kernels when show VF dev") > Fixes: f89a2a05ffa9 ("Add support to configure SR-IOV VF minimum and maximum Tx rate through ip tool") > Fixes: ae7229d5f99e ("ip: Add support for setting and showing SR-IOV virtual funtion link params") > Fixes: d0e720111aad ("ip: ipaddress.c: add support for json output") > Signed-off-by: Tariq Toukan Applied to master.