From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shards.monkeyblade.net ([184.105.139.130]:53698 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932430AbeCLCso (ORCPT ); Sun, 11 Mar 2018 22:48:44 -0400 Date: Sun, 11 Mar 2018 22:48:41 -0400 (EDT) Message-Id: <20180311.224841.884484260613999903.davem@davemloft.net> To: ogerlitz@mellanox.com Cc: paulb@mellanox.com, tgraf@suug.ch, herbert@gondor.apana.org.au, netdev@vger.kernel.org, kliteyn@mellanox.com, roid@mellanox.com, shahark@mellanox.com, markb@mellanox.com, jiri@mellanox.com, matanb@mellanox.com Subject: Re: [PATCH net v4 0/2] rhashtable: Fix rhltable duplicates insertion From: David Miller In-Reply-To: References: <1520431213-61553-1-git-send-email-paulb@mellanox.com> <20180307.112342.1350862113264771178.davem@davemloft.net> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: From: Or Gerlitz Date: Sun, 11 Mar 2018 11:16:44 +0200 > On 3/7/2018 6:23 PM, David Miller wrote: >> From: Paul Blakey >> Date: Wed, 7 Mar 2018 16:00:11 +0200 >> >>> On our mlx5 driver fs_core.c, we use the rhltable interface to store >>> flow groups. We noticed that sometimes we get a warning that flow group isn't >>> found at removal. This rare case was caused when a specific scenario happened, >>> insertion of a flow group with a similar match criteria (a duplicate), >>> but only where the flow group rhash_head was second (or not first) >>> on the relevant rhashtable bucket list. > >> I already applied v3, sorry. But I did add Herbert's ACKs. > > Hi Dave, > > In mlx5 we use this facility since 4.14, can you please push to > -stable of at least 4.14 if not earlier? Ok, queued up.