From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Williamson Subject: Re: [pci PATCH v4 1/4] pci-iov: Add support for unmanaged SR-IOV Date: Sun, 11 Mar 2018 21:59:09 -0600 Message-ID: <20180311215909.16ed4bf1@t450s.home> References: <20180308185507.5433.98830.stgit@localhost.localdomain> <20180308190047.5433.77952.stgit@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: bhelgaas@google.com, alexander.h.duyck@intel.com, linux-pci@vger.kernel.org, virtio-dev@lists.oasis-open.org, kvm@vger.kernel.org, netdev@vger.kernel.org, dan.daly@intel.com, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, keith.busch@intel.com, netanel@amazon.com, mheyne@amazon.de, liang-min.wang@intel.com, mark.d.rustad@intel.com, dwmw2@infradead.org, hch@lst.de, dwmw@amazon.co.uk To: Alexander Duyck Return-path: In-Reply-To: <20180308190047.5433.77952.stgit@localhost.localdomain> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Thu, 08 Mar 2018 11:02:29 -0800 Alexander Duyck wrote: > From: Alexander Duyck > > This patch is meant to add some basic functionality to support for SR-IOV > on devices when the VFs are not managed by some other entity in the device > other than the kernel. > > A new sysfs value called sriov_unmanaged_autoprobe has been added. This > value is used as the drivers_autoprobe setting of the VFs when they are > being managed by an external entity such as device firmware instead of > being managed by the kernel. > > One side effect of this change is that the sriov_drivers_autoprobe and > sriov_unmanaged_autoprobe will only apply their updates when SR-IOV VFs > are allocated. Attempts to update them when SR-IOV is in use will only > update the local value and will not update sriov->autoprobe. > > Signed-off-by: Alexander Duyck > --- I still struggle to understand why we need this "unmanaged" complication and how a user of the sysfs API is expected to have any idea whether a PF is managed or unmanaged and why they should care. Can't we just have a pci_simple_sriov_configure() helper and ignore this unmanaged business? Thanks, Alex