From: David Miller <davem@davemloft.net>
To: felix.manlunas@cavium.com
Cc: netdev@vger.kernel.org, raghu.vatsavayi@cavium.com,
derek.chickles@cavium.com, satananda.burla@cavium.com,
veerasenareddy.burru@cavium.com
Subject: Re: [PATCH V2 net-next] liquidio: fix ndo_change_mtu to always return correct status to the caller
Date: Mon, 12 Mar 2018 11:01:05 -0400 (EDT) [thread overview]
Message-ID: <20180312.110105.1899349673935917534.davem@davemloft.net> (raw)
In-Reply-To: <20180310081735.GA6288@felix-thinkpad.cavium.com>
From: Felix Manlunas <felix.manlunas@cavium.com>
Date: Sat, 10 Mar 2018 00:17:35 -0800
> From: Veerasenareddy Burru <veerasenareddy.burru@cavium.com>
>
> In a scenario where the command queued to firmware get dropped or times
> out, MTU change from host will not propagate to firmware. So, it is
> required for host driver to wait for response from firmware or timeout
> and then return correct status to caller of ndo_change_mtu.
>
> Also moved the common code for MTU change from PF and VF driver files to
> common file lio_core.c
>
> Signed-off-by: Veerasenareddy Burru <veerasenareddy.burru@cavium.com>
> Signed-off-by: Felix Manlunas <felix.manlunas@cavium.com>
> ---
> Patch Change Log:
> V1 -> V2:
> Remove unnecessary log message "MTU changed from %d to %d\n" as
> suggested by David Miller
Applied, thank you.
prev parent reply other threads:[~2018-03-12 15:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-10 8:17 [PATCH V2 net-next] liquidio: fix ndo_change_mtu to always return correct status to the caller Felix Manlunas
2018-03-12 15:01 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180312.110105.1899349673935917534.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=derek.chickles@cavium.com \
--cc=felix.manlunas@cavium.com \
--cc=netdev@vger.kernel.org \
--cc=raghu.vatsavayi@cavium.com \
--cc=satananda.burla@cavium.com \
--cc=veerasenareddy.burru@cavium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).