From: David Miller <davem@davemloft.net>
To: s.mesoraca16@gmail.com
Cc: linux-kernel@vger.kernel.org,
kernel-hardening@lists.openwall.com, netdev@vger.kernel.org,
paulmck@linux.vnet.ibm.com, rientjes@google.com,
elena.reshetova@intel.com, ishkamiel@gmail.com,
keescook@chromium.org
Subject: Re: [PATCH] net: llc: drop VLA in llc_sap_mcast()
Date: Mon, 12 Mar 2018 11:14:32 -0400 (EDT) [thread overview]
Message-ID: <20180312.111432.849792523664957837.davem@davemloft.net> (raw)
In-Reply-To: <1520802724-17509-1-git-send-email-s.mesoraca16@gmail.com>
From: Salvatore Mesoraca <s.mesoraca16@gmail.com>
Date: Sun, 11 Mar 2018 22:12:04 +0100
> Avoid a VLA[1] by using a real constant expression instead of a variable.
> The compiler should be able to optimize the original code and avoid using
> an actual VLA. Anyway this change is useful because it will avoid a false
> positive with -Wvla, it might also help the compiler generating better
> code.
>
> [1] https://lkml.org/lkml/2018/3/7/621
>
> Signed-off-by: Salvatore Mesoraca <s.mesoraca16@gmail.com>
Applied.
next prev parent reply other threads:[~2018-03-12 15:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-11 21:12 [PATCH] net: llc: drop VLA in llc_sap_mcast() Salvatore Mesoraca
2018-03-12 15:14 ` David Miller [this message]
2018-03-12 16:47 ` Salvatore Mesoraca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180312.111432.849792523664957837.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=elena.reshetova@intel.com \
--cc=ishkamiel@gmail.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=rientjes@google.com \
--cc=s.mesoraca16@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).