From: David Miller <davem@davemloft.net>
To: weiyongjun1@huawei.com
Cc: vyasevich@gmail.com, nhorman@tuxdriver.com, lucien.xin@gmail.com,
linux-sctp@vger.kernel.org, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net-next] sctp: fix error return code in sctp_sendmsg_new_asoc()
Date: Mon, 12 Mar 2018 11:19:03 -0400 (EDT) [thread overview]
Message-ID: <20180312.111903.1047457001442236332.davem@davemloft.net> (raw)
In-Reply-To: <1520856964-132516-1-git-send-email-weiyongjun1@huawei.com>
From: Wei Yongjun <weiyongjun1@huawei.com>
Date: Mon, 12 Mar 2018 12:16:04 +0000
> Return error code -EINVAL in the address len check error handling
> case since 'err' can be overwrite to 0 by 'err = sctp_verify_addr()'
> in the for loop.
>
> Fixes: 2c0dbaa0c43d ("sctp: add support for SCTP_DSTADDRV4/6 Information for sendmsg")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Xin, I do not want to have a bug fix like this blocked because of that
SCTP options merge nightmare which is of no fault of our own.
next prev parent reply other threads:[~2018-03-12 15:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-12 12:16 [PATCH net-next] sctp: fix error return code in sctp_sendmsg_new_asoc() Wei Yongjun
2018-03-12 13:38 ` Xin Long
2018-03-12 15:50 ` Marcelo Ricardo Leitner
2018-03-12 15:19 ` David Miller [this message]
2018-03-12 17:34 ` Xin Long
2018-03-12 15:40 ` Neil Horman
2018-03-13 3:03 ` [PATCH net-next v2] " Wei Yongjun
2018-03-13 6:57 ` Xin Long
2018-03-13 10:48 ` Neil Horman
2018-03-13 14:45 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180312.111903.1047457001442236332.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-sctp@vger.kernel.org \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=vyasevich@gmail.com \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).