From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:60314 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751260AbeCLPTF (ORCPT
        <rfc822;netdev@vger.kernel.org>); Mon, 12 Mar 2018 11:19:05 -0400
Date: Mon, 12 Mar 2018 11:19:03 -0400 (EDT)
Message-Id: <20180312.111903.1047457001442236332.davem@davemloft.net>
To: weiyongjun1@huawei.com
Cc: vyasevich@gmail.com, nhorman@tuxdriver.com, lucien.xin@gmail.com,
        linux-sctp@vger.kernel.org, netdev@vger.kernel.org,
        kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net-next] sctp: fix error return code in
 sctp_sendmsg_new_asoc()
From: David Miller <davem@davemloft.net>
In-Reply-To: <1520856964-132516-1-git-send-email-weiyongjun1@huawei.com>
References: <1520856964-132516-1-git-send-email-weiyongjun1@huawei.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Wei Yongjun <weiyongjun1@huawei.com>
Date: Mon, 12 Mar 2018 12:16:04 +0000

> Return error code -EINVAL in the address len check error handling
> case since 'err' can be overwrite to 0 by 'err = sctp_verify_addr()'
> in the for loop.
> 
> Fixes: 2c0dbaa0c43d ("sctp: add support for SCTP_DSTADDRV4/6 Information for sendmsg")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>

Xin, I do not want to have a bug fix like this blocked because of that
SCTP options merge nightmare which is of no fault of our own.