From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shards.monkeyblade.net ([184.105.139.130]:39102 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932190AbeCMA7b (ORCPT ); Mon, 12 Mar 2018 20:59:31 -0400 Date: Mon, 12 Mar 2018 20:59:27 -0400 (EDT) Message-Id: <20180312.205927.730960247311710768.davem@davemloft.net> To: tlfalcon@linux.vnet.ibm.com Cc: netdev@vger.kernel.org, jallen@linux.vnet.ibm.com, nfont@linux.vnet.ibm.com Subject: Re: [PATCH net-next v2 0/4] ibmvnic: Fix VLAN and other device errata From: David Miller In-Reply-To: References: <1520873465-23312-1-git-send-email-tlfalcon@linux.vnet.ibm.com> <20180312.125612.912873724451108597.davem@davemloft.net> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: From: Thomas Falcon Date: Mon, 12 Mar 2018 17:07:38 -0500 > On 03/12/2018 11:56 AM, David Miller wrote: >> From: Thomas Falcon >> Date: Mon, 12 Mar 2018 11:51:01 -0500 >> >>> This patch series contains fixes for VLAN and other backing hardware >>> errata. The VLAN fixes are mostly to account for the additional four >>> bytes VLAN header in TX descriptors and buffers, when applicable. >>> >>> The other fixes for device errata are to pad small packets to avoid a >>> possible connection error that can occur when some devices attempt to >>> transmit small packets. The other fixes are GSO related. Some devices >>> cannot handle a smaller MSS or a packet with a single segment, so >>> disable GSO in those cases. >>> >>> v2: Fix style mistake (unneeded brackets) in patch 3/4 >> Series applied, thanks Thomas. >> > Really sorry about this, but 3/4 is still wrong. There is actually a compiler warning caused by it, which I'm surprised wasn't caught by the test robot. Is there still time to send a v3? If it's in my tree you must send a fixup patch.