From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shards.monkeyblade.net ([184.105.139.130]:39114 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751377AbeCMBA6 (ORCPT ); Mon, 12 Mar 2018 21:00:58 -0400 Date: Mon, 12 Mar 2018 21:00:56 -0400 (EDT) Message-Id: <20180312.210056.192041185878126371.davem@davemloft.net> To: hkallweit1@gmail.com Cc: andrew@lunn.ch, f.fainelli@gmail.com, netdev@vger.kernel.org Subject: Re: [PATCH net-next] net: phy: set link state to down when creating the phy_device From: David Miller In-Reply-To: References: Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: From: Heiner Kallweit Date: Sun, 11 Mar 2018 15:00:37 +0100 > Currently the link state is initialized to "up" when the phy_device is > being created. This is not consistent with the phy state being > initialized to PHY_DOWN. > > Usually this doen't do any harm because the link state is updated > once the PHY reaches state PHY_AN. However e.g. if a LAN port isn't > used and the PHY remains down this inconsistency remains and calls > to functions like phy_print_status() give false results. > Therefore change the initialization to link being down. > > Signed-off-by: Heiner Kallweit Applied, thank you.