From: Kalle Valo <kvalo@codeaurora.org>
To: tcharding <me@tobin.cc>
Cc: "Tobin C. Harding" <me@tobin.cc>,
kernel-hardening@lists.openwall.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-wireless@vger.kernel.org, Tycho Andersen <tycho@tycho.ws>,
Kees Cook <keescook@chromium.org>
Subject: Re: [RESEND] rsi: Remove stack VLA usage
Date: Mon, 12 Mar 2018 09:46:06 +0000 (UTC) [thread overview]
Message-ID: <20180312094606.7197F607F5@smtp.codeaurora.org> (raw)
In-Reply-To: <1520819022-15238-1-git-send-email-me@tobin.cc>
tcharding <me@tobin.cc> wrote:
> The kernel would like to have all stack VLA usage removed[1]. rsi uses
> a VLA based on 'blksize'. Elsewhere in the SDIO code maximum block size
> is defined using a magic number. We can use a pre-processor defined
> constant and declare the array to maximum size. We add a check before
> accessing the array in case of programmer error.
>
> [1]: https://lkml.org/lkml/2018/3/7/621
>
> Signed-off-by: Tobin C. Harding <me@tobin.cc>
Tobin, your name in patchwork.kernel.org is just "tcharding" then it should be
"Tobin C. Harding". Patchwork is braindead in a way as it takes the name from
it's database instead of the From header of the patch in question.
I can fix that manually but it would be helpful if you could register to
patchwork and fix your name during registration. You have only one chance to
fix your name (another braindead feature!) so be careful :)
--
https://patchwork.kernel.org/patch/10274983/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2018-03-12 9:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-12 1:43 [RESEND PATCH] rsi: Remove stack VLA usage Tobin C. Harding
2018-03-12 2:06 ` Larry Finger
2018-03-13 20:09 ` Tobin C. Harding
2018-03-12 9:46 ` Kalle Valo [this message]
2018-03-12 9:46 ` [RESEND] " Kalle Valo
2018-03-13 16:52 ` Kalle Valo
2018-03-13 16:52 ` Kalle Valo
[not found] ` <20180312094606.8192B6081A@smtp.codeaurora.org>
2018-03-13 20:17 ` tcharding
2018-03-13 21:00 ` Andy Shevchenko
2018-03-14 2:11 ` Tobin C. Harding
2018-03-14 2:53 ` Kees Cook
2018-03-14 3:43 ` Tobin C. Harding
2018-03-14 9:19 ` Kalle Valo
2018-03-14 20:19 ` Tobin C. Harding
2018-03-15 9:07 ` Kalle Valo
2018-03-14 9:11 ` Kalle Valo
2018-03-14 9:05 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180312094606.7197F607F5@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=me@tobin.cc \
--cc=netdev@vger.kernel.org \
--cc=tycho@tycho.ws \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).