From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx3-rdu2.redhat.com ([66.187.233.73]:43082 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751229AbeCLN25 (ORCPT ); Mon, 12 Mar 2018 09:28:57 -0400 Date: Mon, 12 Mar 2018 14:28:50 +0100 From: Stefano Brivio To: Atul Gupta Cc: davejwatson@fb.com, davem@davemloft.net, herbert@gondor.apana.org.au, sd@queasysnail.net, linux-crypto@vger.kernel.org, netdev@vger.kernel.org, ganeshgr@chelsio.com Subject: Re: [PATCH v10 crypto 08/11] chtls: CPL handler definition Message-ID: <20180312142850.3067969f@epycfail> In-Reply-To: <1520622616-6557-7-git-send-email-atul.gupta@chelsio.com> References: <1520622616-6557-1-git-send-email-atul.gupta@chelsio.com> <1520622616-6557-7-git-send-email-atul.gupta@chelsio.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: On Sat, 10 Mar 2018 00:40:13 +0530 Atul Gupta wrote: > Exchange CPL messages with hardware to program the TLS session > CPL handlers defined to process messages received from chip. > > Signed-off-by: Atul Gupta > --- > drivers/crypto/chelsio/chtls/chtls_cm.c | 2041 +++++++++++++++++++++++++++++++ > net/ipv4/tcp_minisocks.c | 1 + > 2 files changed, 2042 insertions(+) > create mode 100644 drivers/crypto/chelsio/chtls/chtls_cm.c > > diff --git a/drivers/crypto/chelsio/chtls/chtls_cm.c b/drivers/crypto/chelsio/chtls/chtls_cm.c > > [...] > > +static void send_defer_abort_rpl(struct chtls_dev *cdev, struct sk_buff *skb) > +{ > + struct cpl_abort_req_rss *req = cplhdr(skb); > + struct sk_buff *reply_skb; > + > + reply_skb = alloc_skb(sizeof(struct cpl_abort_rpl), > + GFP_KERNEL | __GFP_NOFAIL); > + if (!reply_skb) > + return; This will never happen. By the way, is there really no way to handle a failure here? -- Stefano