From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f194.google.com ([209.85.192.194]:39195 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752342AbeCMI0S (ORCPT ); Tue, 13 Mar 2018 04:26:18 -0400 Received: by mail-pf0-f194.google.com with SMTP id u5so5556409pfh.6 for ; Tue, 13 Mar 2018 01:26:18 -0700 (PDT) From: Taehee Yoo To: davem@davemloft.net Cc: netdev@vger.kernel.org, steffen.klassert@secunet.com, Taehee Yoo Subject: [PATCH] xfrm: fix rcu_read_unlock usage in xfrm_local_error Date: Tue, 13 Mar 2018 17:26:07 +0900 Message-Id: <20180313082607.19409-1-ap420073@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: In the xfrm_local_error, rcu_read_unlock should be called when afinfo is not NULL. because xfrm_state_get_afinfo calls rcu_read_unlock if afinfo is NULL. Signed-off-by: Taehee Yoo --- net/xfrm/xfrm_output.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/net/xfrm/xfrm_output.c b/net/xfrm/xfrm_output.c index 2346867..89b178a7 100644 --- a/net/xfrm/xfrm_output.c +++ b/net/xfrm/xfrm_output.c @@ -285,8 +285,9 @@ void xfrm_local_error(struct sk_buff *skb, int mtu) return; afinfo = xfrm_state_get_afinfo(proto); - if (afinfo) + if (afinfo) { afinfo->local_error(skb, mtu); - rcu_read_unlock(); + rcu_read_unlock(); + } } EXPORT_SYMBOL_GPL(xfrm_local_error); -- 2.9.3