* [PATCH] xfrm: fix rcu_read_unlock usage in xfrm_local_error
@ 2018-03-13 8:26 Taehee Yoo
2018-03-15 10:48 ` Steffen Klassert
0 siblings, 1 reply; 3+ messages in thread
From: Taehee Yoo @ 2018-03-13 8:26 UTC (permalink / raw)
To: davem; +Cc: netdev, steffen.klassert, Taehee Yoo
In the xfrm_local_error, rcu_read_unlock should be called when afinfo
is not NULL. because xfrm_state_get_afinfo calls rcu_read_unlock
if afinfo is NULL.
Signed-off-by: Taehee Yoo <ap420073@gmail.com>
---
net/xfrm/xfrm_output.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/net/xfrm/xfrm_output.c b/net/xfrm/xfrm_output.c
index 2346867..89b178a7 100644
--- a/net/xfrm/xfrm_output.c
+++ b/net/xfrm/xfrm_output.c
@@ -285,8 +285,9 @@ void xfrm_local_error(struct sk_buff *skb, int mtu)
return;
afinfo = xfrm_state_get_afinfo(proto);
- if (afinfo)
+ if (afinfo) {
afinfo->local_error(skb, mtu);
- rcu_read_unlock();
+ rcu_read_unlock();
+ }
}
EXPORT_SYMBOL_GPL(xfrm_local_error);
--
2.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] xfrm: fix rcu_read_unlock usage in xfrm_local_error
2018-03-13 8:26 [PATCH] xfrm: fix rcu_read_unlock usage in xfrm_local_error Taehee Yoo
@ 2018-03-15 10:48 ` Steffen Klassert
2018-03-16 2:30 ` Taehee Yoo
0 siblings, 1 reply; 3+ messages in thread
From: Steffen Klassert @ 2018-03-15 10:48 UTC (permalink / raw)
To: Taehee Yoo; +Cc: davem, netdev
On Tue, Mar 13, 2018 at 05:26:07PM +0900, Taehee Yoo wrote:
> In the xfrm_local_error, rcu_read_unlock should be called when afinfo
> is not NULL. because xfrm_state_get_afinfo calls rcu_read_unlock
> if afinfo is NULL.
>
> Signed-off-by: Taehee Yoo <ap420073@gmail.com>
Can you please add a 'Fixes:' tag, so that it can be
correctly backported to the stable trees?
Thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xfrm: fix rcu_read_unlock usage in xfrm_local_error
2018-03-15 10:48 ` Steffen Klassert
@ 2018-03-16 2:30 ` Taehee Yoo
0 siblings, 0 replies; 3+ messages in thread
From: Taehee Yoo @ 2018-03-16 2:30 UTC (permalink / raw)
To: Steffen Klassert; +Cc: davem, netdev
2018-03-15 19:48 GMT+09:00 Steffen Klassert <steffen.klassert@secunet.com>:
> On Tue, Mar 13, 2018 at 05:26:07PM +0900, Taehee Yoo wrote:
>> In the xfrm_local_error, rcu_read_unlock should be called when afinfo
>> is not NULL. because xfrm_state_get_afinfo calls rcu_read_unlock
>> if afinfo is NULL.
>>
>> Signed-off-by: Taehee Yoo <ap420073@gmail.com>
>
> Can you please add a 'Fixes:' tag, so that it can be
> correctly backported to the stable trees?
>
> Thanks!
Thank you for your review!
I will send V2 patch.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-03-16 2:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-13 8:26 [PATCH] xfrm: fix rcu_read_unlock usage in xfrm_local_error Taehee Yoo
2018-03-15 10:48 ` Steffen Klassert
2018-03-16 2:30 ` Taehee Yoo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).