From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from charlotte.tuxdriver.com ([70.61.120.58]:42205 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932920AbeCMLqH (ORCPT ); Tue, 13 Mar 2018 07:46:07 -0400 Date: Tue, 13 Mar 2018 07:45:22 -0400 From: Neil Horman To: Kirill Tkhai Cc: davem@davemloft.net, vyasevich@gmail.com, jon.maloy@ericsson.com, ying.xue@windriver.com, santosh.shilimkar@oracle.com, netdev@vger.kernel.org Subject: Re: [PATCH net-next 2/4] net: Convert sctp_ctrlsock_ops Message-ID: <20180313114522.GC18164@hmswarspite.think-freely.org> References: <152093726634.31266.4973922580771632781.stgit@localhost.localdomain> <152093742247.31266.12266517837915305348.stgit@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <152093742247.31266.12266517837915305348.stgit@localhost.localdomain> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, Mar 13, 2018 at 01:37:02PM +0300, Kirill Tkhai wrote: > These pernet_operations create and destroy net::sctp::ctl_sock. > Since pernet_operations do not send sctp packets each other, > they look safe to be marked as async. > > Signed-off-by: Kirill Tkhai > --- > net/sctp/protocol.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/net/sctp/protocol.c b/net/sctp/protocol.c > index 32be52304f98..606361ee9e4a 100644 > --- a/net/sctp/protocol.c > +++ b/net/sctp/protocol.c > @@ -1354,6 +1354,7 @@ static void __net_init sctp_ctrlsock_exit(struct net *net) > static struct pernet_operations sctp_ctrlsock_ops = { > .init = sctp_ctrlsock_init, > .exit = sctp_ctrlsock_exit, > + .async = true, > }; > > /* Initialize the universe into something sensible. */ > > Acked-by: Neil Horman