From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com ([134.134.136.65]:31092 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751997AbeCMUfZ (ORCPT ); Tue, 13 Mar 2018 16:35:25 -0400 From: Vinicius Costa Gomes To: netdev@vger.kernel.org Cc: Vinicius Costa Gomes , randy.e.witt@intel.com, davem@davemloft.net, eric.dumazet@gmail.com Subject: [PATCH net-next 2/2] skbuff: Fix not waking applications when errors are enqueued Date: Tue, 13 Mar 2018 13:35:19 -0700 Message-Id: <20180313203519.8638-3-vinicius.gomes@intel.com> In-Reply-To: <20180313203519.8638-1-vinicius.gomes@intel.com> References: <20180313203519.8638-1-vinicius.gomes@intel.com> Sender: netdev-owner@vger.kernel.org List-ID: When errors are enqueued to the error queue via sock_queue_err_skb() function, it is possible that the waiting application is not notified. Calling 'sk->sk_data_ready()' would not notify applications that selected only POLLERR events in poll() (for example). Reported-by: Randy E. Witt Signed-off-by: Vinicius Costa Gomes --- net/core/skbuff.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/skbuff.c b/net/core/skbuff.c index 715c13495ba6..6def3534f509 100644 --- a/net/core/skbuff.c +++ b/net/core/skbuff.c @@ -4181,7 +4181,7 @@ int sock_queue_err_skb(struct sock *sk, struct sk_buff *skb) skb_queue_tail(&sk->sk_error_queue, skb); if (!sock_flag(sk, SOCK_DEAD)) - sk->sk_data_ready(sk); + sk->sk_error_report(sk); return 0; } EXPORT_SYMBOL(sock_queue_err_skb); -- 2.16.2