* [PATCH net-next] sunvnet: does not support GSO for sctp
@ 2018-03-14 17:56 cathy.zhou
2018-03-14 18:01 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: cathy.zhou @ 2018-03-14 17:56 UTC (permalink / raw)
To: davem, netdev; +Cc: sparclinux
From: Cathy Zhou <Cathy.Zhou@Oracle.COM>
The NETIF_F_GSO_SOFTWARE implies support for GSO on SCTP, but the
sunvnet driver does not support GSO for sctp. Here we remove the
NETIF_F_GSO_SOFTWARE feature flag and only report NETIF_F_ALL_TSO
instead.
Signed-off-by: Cathy Zhou <Cathy.Zhou@Oracle.COM>
Signed-off-by: Shannon Nelson <shannon.nelson@oracle.com>
---
drivers/net/ethernet/sun/sunvnet.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ethernet/sun/sunvnet.c b/drivers/net/ethernet/sun/sunvnet.c
index 63d3d6b..a94f504 100644
--- a/drivers/net/ethernet/sun/sunvnet.c
+++ b/drivers/net/ethernet/sun/sunvnet.c
@@ -312,7 +312,7 @@ static void vnet_poll_controller(struct net_device *dev)
dev->ethtool_ops = &vnet_ethtool_ops;
dev->watchdog_timeo = VNET_TX_TIMEOUT;
- dev->hw_features = NETIF_F_TSO | NETIF_F_GSO | NETIF_F_GSO_SOFTWARE |
+ dev->hw_features = NETIF_F_TSO | NETIF_F_GSO | NETIF_F_ALL_TSO |
NETIF_F_HW_CSUM | NETIF_F_SG;
dev->features = dev->hw_features;
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] sunvnet: does not support GSO for sctp
2018-03-14 17:56 [PATCH net-next] sunvnet: does not support GSO for sctp cathy.zhou
@ 2018-03-14 18:01 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-03-14 18:01 UTC (permalink / raw)
To: cathy.zhou; +Cc: netdev, sparclinux
From: cathy.zhou@oracle.com
Date: Wed, 14 Mar 2018 10:56:07 -0700
> From: Cathy Zhou <Cathy.Zhou@Oracle.COM>
>
> The NETIF_F_GSO_SOFTWARE implies support for GSO on SCTP, but the
> sunvnet driver does not support GSO for sctp. Here we remove the
> NETIF_F_GSO_SOFTWARE feature flag and only report NETIF_F_ALL_TSO
> instead.
>
> Signed-off-by: Cathy Zhou <Cathy.Zhou@Oracle.COM>
> Signed-off-by: Shannon Nelson <shannon.nelson@oracle.com>
Since this is a bug fix I'm applying this to the 'net' tree.
Thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-14 18:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-14 17:56 [PATCH net-next] sunvnet: does not support GSO for sctp cathy.zhou
2018-03-14 18:01 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).