From: Dan Carpenter <dan.carpenter@oracle.com>
To: Mohammed Gamal <mgamal@redhat.com>
Cc: otubo@redhat.com, sthemmin@microsoft.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, devel@linuxdriverproject.org,
vkuznets@redhat.com, davem@davemloft.net
Subject: Re: [PATCH] hv_netvsc: Make sure out channel is fully opened on send
Date: Wed, 14 Mar 2018 11:27:01 +0300 [thread overview]
Message-ID: <20180314082701.2inzz2etg67r3zry@mwanda> (raw)
In-Reply-To: <1520968010-20733-1-git-send-email-mgamal@redhat.com>
On Tue, Mar 13, 2018 at 08:06:50PM +0100, Mohammed Gamal wrote:
> @@ -791,6 +791,7 @@ static inline int netvsc_send_pkt(
> VMBUS_DATA_PACKET_FLAG_COMPLETION_REQUESTED);
> }
>
> + ring_avail = hv_ringbuf_avail_percent(&out_channel->outbound);
> if (ret == 0) {
> atomic_inc_return(&nvchan->queue_sends);
>
Could you move the assignment inside the "ret == 0" path closer to where
it's used?
regards,
dan carpenter
next prev parent reply other threads:[~2018-03-14 8:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-13 19:06 [PATCH] hv_netvsc: Make sure out channel is fully opened on send Mohammed Gamal
2018-03-13 19:35 ` Stephen Hemminger
2018-03-14 9:22 ` Mohammed Gamal
2018-03-15 16:24 ` Mohammed Gamal
2018-03-15 17:40 ` Stephen Hemminger
2018-03-14 8:27 ` Dan Carpenter [this message]
2018-03-16 14:16 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2018-09-26 16:34 Mohammed Gamal
2018-09-26 17:13 ` Haiyang Zhang
2018-09-27 8:57 ` Mohammed Gamal
2018-09-27 10:23 ` Stephen Hemminger
2018-09-27 10:31 ` Mohammed Gamal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180314082701.2inzz2etg67r3zry@mwanda \
--to=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=devel@linuxdriverproject.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mgamal@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=otubo@redhat.com \
--cc=sthemmin@microsoft.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox