From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Potapenko Subject: [PATCH] netlink: make sure nladdr has correct size in netlink_connect() Date: Wed, 14 Mar 2018 15:03:22 +0100 Message-ID: <20180314140322.233047-1-glider@google.com> Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: dvyukov@google.com, edumazet@google.com, davem@davemloft.net Return-path: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org KMSAN reports use of uninitialized memory in the case when |alen| is smaller than sizeof(struct netlink_sock), and therefore |nladdr| isn't fully copied from the userspace. Signed-off-by: Alexander Potapenko Fixes: 1da177e4c3f41524 ("Linux-2.6.12-rc2") --- net/netlink/af_netlink.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c index 07e8478068f0..5d49b39e81c3 100644 --- a/net/netlink/af_netlink.c +++ b/net/netlink/af_netlink.c @@ -1085,6 +1085,9 @@ static int netlink_connect(struct socket *sock, struct sockaddr *addr, if (addr->sa_family != AF_NETLINK) return -EINVAL; + if (alen < sizeof(struct netlink_sock)) + return -EINVAL; + if ((nladdr->nl_groups || nladdr->nl_pid) && !netlink_allowed(sock, NL_CFG_F_NONROOT_SEND)) return -EPERM; -- 2.16.2.804.g6dcf76e118-goog