From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Dichtel Subject: [PATCH net] netlink: avoid a double skb free in genlmsg_mcast() Date: Wed, 14 Mar 2018 21:10:23 +0100 Message-ID: <20180314201023.12407-1-nicolas.dichtel@6wind.com> References: <1520899459.23626.87.camel@codethink.co.uk> Cc: davem@davemloft.net, netdev@vger.kernel.org, stable@vger.kernel.org, johannes.berg@intel.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, Nicolas Dichtel To: ben.hutchings@codethink.co.uk Return-path: In-Reply-To: <1520899459.23626.87.camel@codethink.co.uk> Sender: stable-owner@vger.kernel.org List-Id: netdev.vger.kernel.org nlmsg_multicast() consumes always the skb, thus the original skb must be freed only when this function is called with a clone. Fixes: cb9f7a9a5c96 ("netlink: ensure to loop over all netns in genlmsg_multicast_allns()") Reported-by: Ben Hutchings Signed-off-by: Nicolas Dichtel --- net/netlink/genetlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/netlink/genetlink.c b/net/netlink/genetlink.c index 6f02499ef007..b9ce82c9440f 100644 --- a/net/netlink/genetlink.c +++ b/net/netlink/genetlink.c @@ -1106,7 +1106,7 @@ static int genlmsg_mcast(struct sk_buff *skb, u32 portid, unsigned long group, if (!err) delivered = true; else if (err != -ESRCH) - goto error; + return err; return delivered ? 0 : -ESRCH; error: kfree_skb(skb); -- 2.15.1