From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH] vhost: add vsock compat ioctl Date: Wed, 14 Mar 2018 21:05:31 +0200 Message-ID: <20180314210417-mutt-send-email-mst@kernel.org> References: <20180314172605.130483-1-sonnyrao@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, Stefan Hajnoczi , Jason Wang , virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: Sonny Rao Return-path: Content-Disposition: inline In-Reply-To: <20180314172605.130483-1-sonnyrao@chromium.org> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Wed, Mar 14, 2018 at 10:26:05AM -0700, Sonny Rao wrote: > This will allow usage of vsock from 32-bit binaries on a 64-bit > kernel. > > Signed-off-by: Sonny Rao I think you need to convert the pointer argument though. Something along the lines of: #ifdef CONFIG_COMPAT static long vhost_vsock_dev_compat_ioctl(struct file *f, unsigned int ioctl, unsigned long arg) { return vhost_vsock_dev_ioctl(f, ioctl, (unsigned long)compat_ptr(arg)); } #endif > --- > drivers/vhost/vsock.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/vhost/vsock.c b/drivers/vhost/vsock.c > index 0d14e2ff19f16..d0e65e92110e5 100644 > --- a/drivers/vhost/vsock.c > +++ b/drivers/vhost/vsock.c > @@ -705,6 +705,7 @@ static const struct file_operations vhost_vsock_fops = { > .release = vhost_vsock_dev_release, > .llseek = noop_llseek, > .unlocked_ioctl = vhost_vsock_dev_ioctl, > + .compat_ioctl = vhost_vsock_dev_ioctl, > }; > > static struct miscdevice vhost_vsock_misc = { > -- > 2.13.5