Netdev List
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Vinicius Costa Gomes <vinicius.gomes@intel.com>
Cc: netdev@vger.kernel.org, randy.e.witt@intel.com,
	davem@davemloft.net, eric.dumazet@gmail.com
Subject: Re: [PATCH net-next v2 0/2] skbuff: Fix applications not being woken for errors
Date: Thu, 15 Mar 2018 00:39:51 +0100	[thread overview]
Message-ID: <20180314233951.GC16379@lunn.ch> (raw)
In-Reply-To: <20180314215437.14726-1-vinicius.gomes@intel.com>

On Wed, Mar 14, 2018 at 02:54:35PM -0700, Vinicius Costa Gomes wrote:
> Hi,
> 
> Changes from v1:
>  - Fixed comments from Willem de Bruijn, about the order of the
>  options passed to getopt();
>  - Added Reviewed-by and Fixes tags to patch (2);
> 
> Changes from the RFC:
>  - tweaked commit messages;
> 
> Original cover letter:
> 
> This is actually a "bug report"-RFC instead of the more usual "new
> feature"-RFC.
> 
> We are developing an application that uses TX hardware timestamping to
> make some measurements, and during development Randy Witt initially
> reported that the application poll() never unblocked when TX hardware
> timestamping was enabled.

Hi Vinicius

This sounds a lot like an issue i was chasing a month ago with ptp4l
and the newly added PTP support for Marvell switch chips. I was seeing
poll not unblocking, and when it did, the sequence numbers for PTP
messages indicating they were old. But it suddenly started working,
and i've not been able to reproduce it again.

> (my hypothesis is that only triggers when the error is reported from
> a different task context than the application).

The case i was having problems with, it is a kernel task which does
the error reporting, which is clearly a different context to the ptp4l
application. So your hypothesis could be correct.

	     Andrew

      parent reply	other threads:[~2018-03-14 23:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-14 21:54 [PATCH net-next v2 0/2] skbuff: Fix applications not being woken for errors Vinicius Costa Gomes
2018-03-14 21:54 ` [PATCH net-next v2 1/2] selftests/txtimestamp: Add more configurable parameters Vinicius Costa Gomes
2018-03-14 21:54 ` [PATCH net-next v2 2/2] skbuff: Fix not waking applications when errors are enqueued Vinicius Costa Gomes
2018-03-14 23:39 ` Andrew Lunn [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180314233951.GC16379@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=randy.e.witt@intel.com \
    --cc=vinicius.gomes@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox