From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shards.monkeyblade.net ([184.105.139.130]:50032 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751492AbeCOSks (ORCPT ); Thu, 15 Mar 2018 14:40:48 -0400 Date: Thu, 15 Mar 2018 14:40:46 -0400 (EDT) Message-Id: <20180315.144046.1660172203620629706.davem@davemloft.net> To: john.fastabend@gmail.com Cc: ast@kernel.org, daniel@iogearbox.net, davejwatson@fb.com, netdev@vger.kernel.org Subject: Re: [bpf-next PATCH v2 03/18] net: do_tcp_sendpages flag to avoid SKBTX_SHARED_FRAG From: David Miller In-Reply-To: <20180312192319.8039.61347.stgit@john-Precision-Tower-5810> References: <20180312192034.8039.70022.stgit@john-Precision-Tower-5810> <20180312192319.8039.61347.stgit@john-Precision-Tower-5810> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: From: John Fastabend Date: Mon, 12 Mar 2018 12:23:19 -0700 > When calling do_tcp_sendpages() from in kernel and we know the data > has no references from user side we can omit SKBTX_SHARED_FRAG flag. > This patch adds an internal flag, NO_SKBTX_SHARED_FRAG that can be used > to omit setting SKBTX_SHARED_FRAG. > > The flag is not exposed to userspace because the sendpage call from > the splice logic masks out all bits except MSG_MORE. > > Signed-off-by: John Fastabend Acked-by: David S. Miller