From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shards.monkeyblade.net ([184.105.139.130]:50214 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751492AbeCOSnN (ORCPT ); Thu, 15 Mar 2018 14:43:13 -0400 Date: Thu, 15 Mar 2018 14:43:12 -0400 (EDT) Message-Id: <20180315.144312.1968933239629263163.davem@davemloft.net> To: john.fastabend@gmail.com Cc: ast@kernel.org, daniel@iogearbox.net, davejwatson@fb.com, netdev@vger.kernel.org Subject: Re: [bpf-next PATCH v2 17/18] bpf: sockmap sample test for bpf_msg_pull_data From: David Miller In-Reply-To: <20180312192431.8039.36798.stgit@john-Precision-Tower-5810> References: <20180312192034.8039.70022.stgit@john-Precision-Tower-5810> <20180312192431.8039.36798.stgit@john-Precision-Tower-5810> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: From: John Fastabend Date: Mon, 12 Mar 2018 12:24:31 -0700 > This adds an option to test the msg_pull_data helper. This > uses two options txmsg_start and txmsg_end to let the user > specify start and end bytes to pull. > > The options can be used with txmsg_apply, txmsg_cork options > as well as with any of the basic tests, txmsg, txmsg_redir and > txmsg_drop (plus noisy variants) to run pull_data inline with > those tests. By giving user direct control over the variables > we can easily do negative testing as well as positive tests. > > Signed-off-by: John Fastabend Acked-by: David S. Miller