From: David Miller <davem@redhat.com>
To: dsahern@gmail.com
Cc: netdev@vger.kernel.org, idosch@idosch.org
Subject: Re: [PATCH v4 net-next 0/6] net/ipv6: Address checks need to consider the L3 domain
Date: Fri, 16 Mar 2018 11:29:32 -0400 (EDT) [thread overview]
Message-ID: <20180316.112932.603588692693769640.davem@redhat.com> (raw)
In-Reply-To: <20180313152941.31218-1-dsahern@gmail.com>
From: David Ahern <dsahern@gmail.com>
Date: Tue, 13 Mar 2018 08:29:35 -0700
> IPv6 prohibits a local address from being used as a gateway for a route.
> However, it is ok for the gateway to be a local address in a different L3
> domain (e.g., VRF). This allows, for example, veth pairs to connect VRFs.
>
> ip6_route_info_create calls ipv6_chk_addr_and_flags for gateway addresses
> to determine if the address is a local one, but ipv6_chk_addr_and_flags
> does not currently consider L3 domains. As a result routes can not be
> added in one VRF with a nexthop that points to a local address in a
> second VRF.
>
> Resolve by comparing the l3mdev for the passed in device and requiring an
> l3mdev match with the device containing an address. The intent of checking
> for an address on the specified device versus any device in the domain is
> mantained by a new argument to skip the check between the passed in device
> and the device with the address.
...
Series applied, thanks David.
I'd also like to echo Ido's sentiments on your commit log messages, their
attention to detail made this series that much easier to review.
prev parent reply other threads:[~2018-03-16 15:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-13 15:29 [PATCH v4 net-next 0/6] net/ipv6: Address checks need to consider the L3 domain David Ahern
2018-03-13 15:29 ` [PATCH v4 net-next 1/6] net/ipv6: Refactor gateway validation on route add David Ahern
2018-03-14 12:21 ` Ido Schimmel
2018-03-13 15:29 ` [PATCH v4 net-next 2/6] net/ipv6: Change address check to always take a device argument David Ahern
2018-03-14 12:22 ` Ido Schimmel
2018-03-13 15:29 ` [PATCH v4 net-next 3/6] net/ipv6: Add l3mdev check to ipv6_chk_addr_and_flags David Ahern
2018-03-14 12:25 ` Ido Schimmel
2018-03-13 15:29 ` [PATCH v4 net-next 4/6] selftests: fib_tests: Use an alias for ip command David Ahern
2018-03-13 15:29 ` [PATCH v4 net-next 5/6] selftests: fib_tests: Allow user to run a specific test David Ahern
2018-03-13 15:29 ` [PATCH v4 net-next 6/6] selftests: fib_tests: Add IPv6 nexthop spec tests David Ahern
2018-03-16 15:29 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180316.112932.603588692693769640.davem@redhat.com \
--to=davem@redhat.com \
--cc=dsahern@gmail.com \
--cc=idosch@idosch.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).