From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shards.monkeyblade.net ([184.105.139.130]:34282 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752795AbeCPQh0 (ORCPT ); Fri, 16 Mar 2018 12:37:26 -0400 Date: Fri, 16 Mar 2018 12:37:24 -0400 (EDT) Message-Id: <20180316.123724.729271943170129684.davem@davemloft.net> To: vinicius.gomes@intel.com Cc: netdev@vger.kernel.org, randy.e.witt@intel.com, eric.dumazet@gmail.com Subject: Re: [PATCH net] skbuff: Fix not waking applications when errors are enqueued From: David Miller In-Reply-To: <20180314203209.26532-1-vinicius.gomes@intel.com> References: <20180314203209.26532-1-vinicius.gomes@intel.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: From: Vinicius Costa Gomes Date: Wed, 14 Mar 2018 13:32:09 -0700 > When errors are enqueued to the error queue via sock_queue_err_skb() > function, it is possible that the waiting application is not notified. > > Calling 'sk->sk_data_ready()' would not notify applications that > selected only POLLERR events in poll() (for example). > > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > Reported-by: Randy E. Witt > Reviewed-by: Eric Dumazet > Signed-off-by: Vinicius Costa Gomes Applied and queued up for -stable, thank you. Since this is going into 'net', it doesn't need to be in your net-next submission as 'net' changes will (eventually) propagate into net-next. Please fix that up, thank you.