From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:35946 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750921AbeCPSur (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 16 Mar 2018 14:50:47 -0400
Date: Fri, 16 Mar 2018 14:50:45 -0400 (EDT)
Message-Id: <20180316.145045.523457000967766907.davem@davemloft.net>
To: igor.russkikh@aquantia.com
Cc: netdev@vger.kernel.org, darcari@redhat.com,
        pavel.belous@aquantia.com
Subject: Re: [PATCH net 1/7] net: aquantia: Fix hardware reset when SPI may
 rarely hangup
From: David Miller <davem@davemloft.net>
In-Reply-To: <c0a6a02dd93bd4c19a2150884bdd73f5690fbc30.1521192913.git.igor.russkikh@aquantia.com>
References: <cover.1521192913.git.igor.russkikh@aquantia.com>
        <c0a6a02dd93bd4c19a2150884bdd73f5690fbc30.1521192913.git.igor.russkikh@aquantia.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Igor Russkikh <igor.russkikh@aquantia.com>
Date: Fri, 16 Mar 2018 13:53:44 +0300

> diff --git a/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.c b/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.c
> index 967f0fd..0da480b 100644
> --- a/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.c
> +++ b/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.c
> @@ -80,15 +80,14 @@ int hw_atl_utils_initfw(struct aq_hw_s *self, const struct aq_fw_ops **fw_ops)
>  static int hw_atl_utils_soft_reset_flb(struct aq_hw_s *self)
>  {
>  	int k = 0;
> -	u32 gsr;
> +	u32 gsr, val;

Please preserve the reverse christmas tree ordering (longest to shortest line) for
variable declarations here.