From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl0-f67.google.com ([209.85.160.67]:45628 "EHLO mail-pl0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751714AbeCPCgG (ORCPT ); Thu, 15 Mar 2018 22:36:06 -0400 Received: by mail-pl0-f67.google.com with SMTP id v9-v6so5037723plp.12 for ; Thu, 15 Mar 2018 19:36:06 -0700 (PDT) From: Taehee Yoo To: davem@davemloft.net, steffen.klassert@secunet.com Cc: netdev@vger.kernel.org, Taehee Yoo Subject: [PATCH V2] xfrm: fix rcu_read_unlock usage in xfrm_local_error Date: Fri, 16 Mar 2018 11:35:51 +0900 Message-Id: <20180316023551.3213-1-ap420073@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: In the xfrm_local_error, rcu_read_unlock should be called when afinfo is not NULL. because xfrm_state_get_afinfo calls rcu_read_unlock if afinfo is NULL. Fixes: af5d27c4e12b ("xfrm: remove xfrm_state_put_afinfo") Signed-off-by: Taehee Yoo --- V2 : - Add Fixes tag V1 : - Initial patch net/xfrm/xfrm_output.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/net/xfrm/xfrm_output.c b/net/xfrm/xfrm_output.c index 2346867..89b178a7 100644 --- a/net/xfrm/xfrm_output.c +++ b/net/xfrm/xfrm_output.c @@ -285,8 +285,9 @@ void xfrm_local_error(struct sk_buff *skb, int mtu) return; afinfo = xfrm_state_get_afinfo(proto); - if (afinfo) + if (afinfo) { afinfo->local_error(skb, mtu); - rcu_read_unlock(); + rcu_read_unlock(); + } } EXPORT_SYMBOL_GPL(xfrm_local_error); -- 2.9.3