From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
To: Kirill Tkhai <ktkhai@virtuozzo.com>
Cc: santosh.shilimkar@oracle.com, davem@davemloft.net,
netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
rds-devel@oss.oracle.com, edumazet@google.com
Subject: Re: [PATCH RFC RFC] rds: Use NETDEV_UNREGISTER in rds_tcp_dev_event() (then kill NETDEV_UNREGISTER_FINAL)
Date: Fri, 16 Mar 2018 14:53:34 -0400 [thread overview]
Message-ID: <20180316185334.GQ16870@oracle.com> (raw)
In-Reply-To: <856ac399-c934-6a14-1ae7-d921c449c4b1@virtuozzo.com>
On (03/16/18 21:48), Kirill Tkhai wrote:
>
> > Thus I have to spend some time reviewing your patch,
> > and I cannot give you an answer in the next 5 minutes.
>
> No problem, 5 minutes response never required. Thanks for
> your review.
thank you. I would like to take some time this weekend
to understand why v1 of your patch hit the null rtn,
but v2 did not (a superficial glance at the patch suggested
that you were registering twice in both cases, with just
a reordering, so I would like to understand the root-cause of
the null ptr deref with v1)
As for registering 2 times, that needs some comments to
provide guidance for other subsystems. e.g., I found the
large block comment in net-namespace.h very helpful, so lets
please clearly document what and why and when this should
be used.
--Sowmini
next prev parent reply other threads:[~2018-03-16 18:53 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-16 12:38 [PATCH RFC RFC] rds: Use NETDEV_UNREGISTER in rds_tcp_dev_event() (then kill NETDEV_UNREGISTER_FINAL) Kirill Tkhai
2018-03-16 13:00 ` Sowmini Varadhan
2018-03-16 13:17 ` Kirill Tkhai
2018-03-16 13:53 ` Sowmini Varadhan
2018-03-16 14:36 ` Kirill Tkhai
2018-03-16 14:41 ` Kirill Tkhai
2018-03-16 17:29 ` Sowmini Varadhan
2018-03-16 18:14 ` Kirill Tkhai
2018-03-16 18:31 ` Sowmini Varadhan
2018-03-16 18:48 ` Kirill Tkhai
2018-03-16 18:53 ` Sowmini Varadhan [this message]
2018-03-17 14:15 ` Sowmini Varadhan
2018-03-17 21:13 ` Kirill Tkhai
2018-03-17 21:26 ` [rds-devel] " Sowmini Varadhan
2018-03-17 21:55 ` Kirill Tkhai
2018-03-18 20:45 ` Sowmini Varadhan
2018-03-19 10:08 ` Kirill Tkhai
2018-03-20 11:37 ` Håkon Bugge
2018-03-20 13:29 ` Sowmini Varadhan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180316185334.GQ16870@oracle.com \
--to=sowmini.varadhan@oracle.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ktkhai@virtuozzo.com \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rds-devel@oss.oracle.com \
--cc=santosh.shilimkar@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).